fix: Removed quick access link from selling workspace

[nabinhait]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change modifies erpnext/selling/workspace/selling/selling.json by reordering the content blocks within the workspace configuration. The "Quick Access" header is removed from the sequence, and the "Reports & Masters" header is repositioned to appear earlier. Individual card definitions remain unchanged; only their relative ordering is affected. The file's modification timestamp is updated to reflect the change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a description explaining why the quick access link was removed and what impact this has on the selling workspace.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing the quick access link from the selling workspace, which aligns with the reordering of content blocks and removal of the Quick Access header.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@erpnext/selling/workspace/selling/selling.json`:
- Line 9: The workspace JSON's content string contains incorrect
number_card_name values causing widgets to not render; update the "content"
field entry that currently uses "Sales Orders" and "Average Order Value" to the
canonical Number Card names "Sales Orders Count" and "Average Sales Order Value"
respectively (these are the values referenced by the number_card entries and
correspond to the number card docs used by the workspace; look for the JSON
object with type "number_card" and ids "43fzlS1qZg" and "0Ioq-P11FP" to make the
replacements).

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for Number Card fixtures and definitions
echo "=== Searching for Number Card DocType files ==="
find . -type f -name "*number_card*" | head -20

echo -e "\n=== Searching for 'Sales Orders' references in JSON files ==="
rg -n "Sales Orders" --type json | grep -i "number_card\|content" | head -20

echo -e "\n=== Searching for 'Average Order Value' references in JSON files ==="
rg -n "Average Order Value" --type json | head -20

echo -e "\n=== Searching for 'Sales Orders Count' references ==="
rg -n "Sales Orders Count" --type json | head -20

echo -e "\n=== Searching for 'Average Sales Order Value' references ==="
rg -n "Average Sales Order Value" --type json | head -20

Repository: frappe/erpnext

Length of output: 6339

---

🏁 Script executed:

#!/bin/bash
# Look for Number Card fixture files in the standard ERPNext location
echo "=== Looking for number_card fixture files ==="
find . -path "*/fixtures/*number_card*" -o -path "*/doctype/*number_card*" | head -30

echo -e "\n=== Checking selling workspace for the exact structure ==="
cat -n erpnext/selling/workspace/selling/selling.json | sed -n '629,642p'

Repository: frappe/erpnext

Length of output: 546

---

🏁 Script executed:

#!/bin/bash
# Search for any Number Card definitions or fixtures that might define the canonical names
echo "=== Searching for Number Card doctype definitions ==="
fd "number_card" --type d

echo -e "\n=== Looking for JSON files that define Number Cards ==="
rg -l "doctype.*number.card\|number.*card.*doctype" --type json | head -10

Repository: frappe/erpnext

Length of output: 436

---

Fix number_card_name values in the content field — widgets will not render with incorrect references.

The content field on line 9 references two number cards that do not exist in the codebase:

content field	Actual DocType name	Status
"Sales Orders"	"Sales Orders Count"	✗ Not found
"Average Order Value"	"Average Sales Order Value"	✗ Not found
"Total Sales Amount"	"Total Sales Amount"	✓ Correct

The canonical Number Card DocType records are Sales Orders Count and Average Sales Order Value (confirmed in erpnext/selling/number_card/sales_orders_count/ and erpnext/selling/number_card/average_sales_order_value/). The number_cards child table correctly references these names, but the content field—which actually renders the workspace widgets—uses wrong names. This will cause two widgets to silently fail to display.

Update line 9 to reference "Sales Orders Count" and "Average Sales Order Value" instead.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@erpnext/selling/workspace/selling/selling.json` at line 9, The workspace
JSON's content string contains incorrect number_card_name values causing widgets
to not render; update the "content" field entry that currently uses "Sales
Orders" and "Average Order Value" to the canonical Number Card names "Sales
Orders Count" and "Average Sales Order Value" respectively (these are the values
referenced by the number_card entries and correspond to the number card docs
used by the workspace; look for the JSON object with type "number_card" and ids
"43fzlS1qZg" and "0Ioq-P11FP" to make the replacements).

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.