Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Feature/create collection return address #96

Closed
asiniscalchi wants to merge 13 commits into from
Closed

Feature/create collection return address #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3f38e5b
added collection counter
asiniscalchi Jul 28, 2023
65136fb
test to check the counter increase on creation
asiniscalchi Jul 28, 2023
5f67a28
counter works
asiniscalchi Jul 28, 2023
bea9272
create_collection generate the collectionId
asiniscalchi Jul 28, 2023
460066c
fix prevcompiled comntract
asiniscalchi Jul 28, 2023
bcb3329
collectio_id is not payable
asiniscalchi Jul 29, 2023
d85195f
Merge branch 'dev' into feature/create-collection-return-contract-add…
asiniscalchi Jul 29, 2023
0fc56da
refactoring
asiniscalchi Jul 29, 2023
49c425b
fmt
asiniscalchi Jul 29, 2023
021de5a
CollectionId is Unsigned
asiniscalchi Jul 29, 2023
5dd8c0e
fmt
asiniscalchi Jul 29, 2023
d2279f5
rollback name refactring for precompile
asiniscalchi Jul 29, 2023
e46f0dd
rollback name refactring for precompile
asiniscalchi Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CollectionId is Unsigned
  • Loading branch information
@asiniscalchi
asiniscalchi committed Jul 29, 2023
commit 021de5ac922f942d7eae092572da1f03555c21a7
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pallets/living-assets-ownership/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ scale-info = { workspace = true, features = ["derive"] }
frame-benchmarking = { workspace = true, optional = true }
frame-support = { workspace = true }
frame-system = { workspace = true }
sp-arithmetic = { workspace = true }

[dev-dependencies]
serde = { workspace = true }
Expand Down
3 changes: 2 additions & 1 deletion pallets/living-assets-ownership/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ mod tests;

#[frame_support::pallet]
pub mod pallet {
use sp_arithmetic::traits::Unsigned;
use frame_support::{
pallet_prelude::{OptionQuery, ValueQuery, *},
sp_runtime::traits::{CheckedAdd, One},
Expand All @@ -32,7 +33,7 @@ pub mod pallet {
/// Because this pallet emits events, it depends on the runtime's definition of an event.
type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
/// Collection id type
type CollectionId: Member + Parameter + MaxEncodedLen + Copy + Default + CheckedAdd + One;
type CollectionId: Member + Parameter + MaxEncodedLen + Copy + Default + CheckedAdd + One + Unsigned;
}

/// Mapping from collection id to owner
Expand Down