Skip to content

Implement max|min, maxBy|minBy and maxByAsync|minByAsync #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelbraaksma merged 4 commits into from
Dec 23, 2023
Merged

Implement max|min, maxBy|minBy and maxByAsync|minByAsync #221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdb316a
Implement `max|min`, `maxBy|minBy` and `maxByAsync|minByAsync`
abelbraaksma Dec 22, 2023
c0c5e80
Add tests for `TaskSeq.min|max|minBy|maxBy` and async variants
abelbraaksma Dec 23, 2023
9a165f1
Fix wrong order of compare function for `minBy|maxBy` and variants
abelbraaksma Dec 23, 2023
2e9541c
Update `readme.md` and package files for `max|min` etc
abelbraaksma Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update readme.md and package files for max|min etc
  • Loading branch information
@abelbraaksma
abelbraaksma committed Dec 23, 2023
commit 2e9541cb51da3f6011ad8c13ca8a5bdda0ab1a9b
16 changes: 11 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,10 @@ This is what has been implemented so far, is planned or skipped:
| 🚫 | `mapFoldBack` | | | [note #2](#note2 "Because of the async nature of TaskSeq sequences, iterating from the back would be bad practice. Instead, materialize the sequence to a list or array and then apply the 'Back' iterators.") |
| ✅ [#2][] | `mapi` | `mapi` | `mapiAsync` | |
| | `mapi2` | `mapi2` | `mapi2Async` | |
| | `max` | `max` | | |
| | `maxBy` | `maxBy` | `maxByAsync` | |
| | `min` | `min` | | |
| | `minBy` | `minBy` | `minByAsync` | |
| ✅ [#221][]| `max` | `max` | | |
| ✅ [#221][]| `maxBy` | `maxBy` | `maxByAsync` | |
| ✅ [#221][]| `min` | `min` | | |
| ✅ [#221][]| `minBy` | `minBy` | `minByAsync` | |
| ✅ [#2][] | `ofArray` | `ofArray` | | |
| ✅ [#2][] | | `ofAsyncArray` | | |
| ✅ [#2][] | | `ofAsyncList` | | |
Expand Down Expand Up @@ -511,7 +511,12 @@ module TaskSeq =
val mapAsync: mapper: ('T -> #Task<'U>) -> source: TaskSeq<'T> -> TaskSeq<'U>
val mapi: mapper: (int -> 'T -> 'U) -> source: TaskSeq<'T> -> TaskSeq<'U>
val mapiAsync: mapper: (int -> 'T -> #Task<'U>) -> source: TaskSeq<'T> -> TaskSeq<'U>
val ofArray: source: 'T[] -> TaskSeq<'T>
val max: source: TaskSeq<'T> -> Task<'T> when 'T: comparison
val max: source: TaskSeq<'T> -> Task<'T> when 'T: comparison
val maxBy: projection: ('T -> 'U) -> source: TaskSeq<'T> -> Task<'T> when 'U: comparison
val minBy: projection: ('T -> 'U) -> source: TaskSeq<'T> -> Task<'T> when 'U: comparison
val maxByAsync: projection: ('T -> #Task<'U>) -> source: TaskSeq<'T> -> Task<'T> when 'U: comparison
val minByAsync: projection: ('T -> #Task<'U>) -> source: TaskSeq<'T> -> Task<'T> when 'U: comparison val ofArray: source: 'T[] -> TaskSeq<'T>
val ofAsyncArray: source: Async<'T> array -> TaskSeq<'T>
val ofAsyncList: source: Async<'T> list -> TaskSeq<'T>
val ofAsyncSeq: source: seq<Async<'T>> -> TaskSeq<'T>
Expand Down Expand Up @@ -604,6 +609,7 @@ module TaskSeq =
[#209]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/209
[#217]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/217
[#219]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/219
[#221]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/221

[issues]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues
[nuget]: https://www.nuget.org/packages/FSharp.Control.TaskSeq/
9 changes: 5 additions & 4 deletions assets/nuget-package-readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ This is what has been implemented so far, is planned or skipped:
| &#x1f6ab; | `mapFoldBack` | | | [note #2](#note2 "Because of the async nature of TaskSeq sequences, iterating from the back would be bad practice. Instead, materialize the sequence to a list or array and then apply the 'Back' iterators.") |
| &#x2705; [#2][] | `mapi` | `mapi` | `mapiAsync` | |
| | `mapi2` | `mapi2` | `mapi2Async` | |
| | `max` | `max` | | |
| | `maxBy` | `maxBy` | `maxByAsync` | |
| | `min` | `min` | | |
| | `minBy` | `minBy` | `minByAsync` | |
| &#x2705; [#221][]| `max` | `max` | | |
| &#x2705; [#221][]| `maxBy` | `maxBy` | `maxByAsync` | |
| &#x2705; [#221][]| `min` | `min` | | |
| &#x2705; [#221][]| `minBy` | `minBy` | `minByAsync` | |
| &#x2705; [#2][] | `ofArray` | `ofArray` | | |
| &#x2705; [#2][] | | `ofAsyncArray` | | |
| &#x2705; [#2][] | | `ofAsyncList` | | |
Expand Down Expand Up @@ -309,3 +309,4 @@ _The motivation for `readOnly` in `Seq` is that a cast from a mutable array or l
[#209]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/209
[#217]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/217
[#219]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/219
[#221]: https://github.com/fsprojects/FSharp.Control.TaskSeq/issues/221
1 change: 1 addition & 0 deletions release-notes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Release notes:
* TaskSeq.truncate, drop, #209
* TaskSeq.where, whereAsync, #217
* TaskSeq.skipWhile, skipWhileInclusive, skipWhileAsync, skipWhileInclusiveAsync, #219
* TaskSeq.max, min, maxBy, minBy, maxByAsync, minByAsync, #221

- Performance: less thread hops with 'StartImmediateAsTask' instead of 'StartAsTask', fixes #135
- BINARY INCOMPATIBILITY: 'TaskSeq' module is now static members on 'TaskSeq<_>', fixes #184
Expand Down