Skip to content

[v3] [ios] transaction #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 26, 2017
Merged

[v3] [ios] transaction #215

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
15e49a3
Add transaction support to Database Reference.
FrankSalad Jan 6, 2017
dba8c11
Resolve promise and send callback appropriate result.
FrankSalad Jan 6, 2017
69fb950
Cleaner handling chain.
FrankSalad Jan 6, 2017
db3f015
Concurrent transaction queue, serialize access to _transactions Mutab…
FrankSalad Jan 6, 2017
1dc4911
Add to readme
FrankSalad Jan 8, 2017
12a3f1c
Wrap update function in try block.
FrankSalad Jan 8, 2017
5d31027
Fix error 'TypeError: Cannot read property 'snapshot' of undefined'
FrankSalad Jan 8, 2017
8fe95f2
Add timeout
FrankSalad Jan 8, 2017
6ac8fda
Merge branch 'v3' into v3-transaction
FrankSalad Jan 17, 2017
5a735ab
Merge branch 'v3' into v3-transaction
auser Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix error 'TypeError: Cannot read property 'snapshot' of undefined'
  • Loading branch information
@FrankSalad
FrankSalad committed Jan 8, 2017
commit 5d31027be68b2fa74c5c04bb20ac0ab8c50c16c6
2 changes: 1 addition & 1 deletion lib/modules/database/reference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export default class Reference extends ReferenceBase {
transaction(transactionUpdate, onComplete, applyLocally) {
const path = this._dbPath();
return this.db.addTransaction(path, transactionUpdate, applyLocally)
.then(({ snapshot, committed }) => {snapshot: new Snapshot(this, snapshot), committed})
.then((({ snapshot, committed }) => {return {snapshot: new Snapshot(this, snapshot), committed}}).bind(this))
.then(({ snapshot, committed }) => {
if (isFunction(onComplete)) onComplete(null, snapshot);
return {snapshot, committed};
Expand Down