[v3] Support for ref.once('child_added') #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auser
reviewed
Jan 12, 2017
… paths of snapshots returned by callback.
FrankSalad
force-pushed
the
v3-once-child-added
branch
from
51f18e8 to
f1ae6f2
Compare
|
This has completely broken Android database functionality due to the changes that have been made to the Javascript and the data structure it now expects from the native side. Any breaking changes to the native interface should really be implemented on both iOS and Android simultaneously. @auser I'm not sure what the best course of action is here. Whether to revert the changes or wait for somebody to fix Android and properly test that nothing else has broken? Unfortunately I just can't spare the time at the moment to look myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.