Fix crash that happens when Firebase API key gets revoked #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318
This has been really hard to reproduce and track down: When an API key gets revoked the stored auth token is not valid any more, causing this error.
error localizedFailureReason
doesn't contain anything in that case, so it'snil
, causing Objective-C to crash as you can't have it as a value for a dictionary.It's probably save to have the default text here, but feel free to tweak it and modify the PR directly as necessary.
Let me know if you have any other questions. I'm using
firestack
for my side project wwdc.family 👍