Stable rust toolchain migration #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonTulp
approved these changes
Aug 1, 2024
| - name: Check out | ||
| uses: actions/checkout@v3 | ||
| - name: Install toolchain | ||
| run: rustup show |
Contributor
There was a problem hiding this comment.
Why get rid of rustup show line?
Contributor
Author
There was a problem hiding this comment.
This doesnt actually install the toolchain; just shows it. Using GH action instead to deterministically install the correct toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ideally we should migrate to stable rust for toolchain stability; this PR achieves that.
rust-toolchain.tomlrustfmt.tomlas nightly; hence there's a bunch of formatting changes in this PR.rsfiles are formatting changes due to the toolchain updatexrpl-sdk-rustmain branch supports stable, hence the dep is updated it point to that branch; diff here