feat!: Transfer Fees to Treasury #493
Conversation
|
Runtime version has not been increased. |
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 24 24
Lines 2935 2935
=======================================
Hits 2449 2449
Misses 486 486 Continue to review full report at Codecov.
|
enthusiastmartin
left a comment
enthusiastmartin
left a comment
There was a problem hiding this comment.
it looks good to me. it is just an integration of work which hopefully has been done and tested.
I'll leave to @Roznovjak to approve.
Roznovjak
left a comment
Roznovjak
left a comment
There was a problem hiding this comment.
Looks good. There is probably no documentation requiring changes. But I'm not sure about tests. Do we want to add some tests? The problem with testing is that I'm not sure how we can call a TX and charge a fee for it without using dedicated struct for handling fees (ChargeTransactionPayment, as used in the tests in the TX multi payment pallet).
i believe an integration test would be quite useful for this feature. Or update existing one to check if fees are correctly transferred to treasury. |
Cargo.toml
Outdated
| pallet-transaction-multi-payment = { git = "https://github.com/galacticcouncil//warehouse", rev = "c73846ec093357fea1b35da5c56ecb37592d4896"} | ||
| pallet-asset-registry= { git = "https://github.com/galacticcouncil//warehouse", rev = "c73846ec093357fea1b35da5c56ecb37592d4896"} | ||
| hydradx-traits = { git = "https://github.com/galacticcouncil//warehouse", rev = "c73846ec093357fea1b35da5c56ecb37592d4896"} | ||
| pallet-price-oracle = { git = "https://github.com/galacticcouncil//warehouse", rev = "50c82ab02bb5baf99b263342dc5d4cc7e62c7e88"} |
There was a problem hiding this comment.
Why we dont use the very latest warehouse revision?
this one : 7052eeab309742dccfe7e307c15fc4f780713553
There was a problem hiding this comment.
I have updated to the latest revision.
Use the
TransferFeestype introduced in galacticcouncil/warehouse#42 in the runtimes and fix various type/integration issues.Related Issue
Fixes: #412
Motivation and Context
This transfers fees to the treasury instead of burning them.
In addition it also unblocks other PRs depending on a recent version of the warehouse.
How Has This Been Tested?
Checklist: