Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Conversation

@enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Mar 3, 2023

  • required to install protobuf compiler
    • sudo apt-get install protobuf-compiler
  • for math repo, required to install m4
    • sudo apt-get install m4
  • pallet stuff renamed
    • Event → RuntimeEvent
      • From<Event> + IsType<::RuntimeEvent>;
    • Origin → RuntimeOrigin
    • Call → RuntimeCall
  • extrinsics need call_index ( otherwise depreated warning )
    • #[pallet::call_index(0)]
  • orml traits
    • OnDust trait move into submodule called currency
  • NFT pallet
    • InspectEnumerable trait changed - needs closer look to verify f reimplemented correcy.
  • pallet currencies
    • check if changes in orml currencies to ensure no bugs fixed ?
  • orml tokens
    • callbacks OnDust,OnNewAccoutn and OnKilledAccount combined into one CurrencyHooks.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.81 ⚠️

Comparison is base (0047e9c) 74.15% compared to head (ec42a11) 73.34%.

❗ Current head ec42a11 differs from pull request most recent head 474064e. Consider uploading reports for the commit 474064e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   74.15%   73.34%   -0.81%     
==========================================
  Files          45       45              
  Lines        3707     3651      -56     
==========================================
- Hits         2749     2678      -71     
- Misses        958      973      +15     
Impacted Files Coverage Δ
adapters/src/inspect.rs 16.00% <0.00%> (-1.40%) ⬇️
asset-registry/src/lib.rs 81.63% <ø> (ø)
collator-rewards/src/lib.rs 80.95% <ø> (ø)
currencies/src/lib.rs 62.40% <ø> (ø)
duster/src/lib.rs 60.81% <ø> (ø)
duster/src/migration.rs 0.00% <ø> (ø)
ema-oracle/src/lib.rs 86.57% <ø> (ø)
faucet/src/lib.rs 82.35% <ø> (ø)
liquidity-mining/src/lib.rs 75.74% <ø> (ø)
otc/src/lib.rs 90.00% <ø> (ø)
... and 10 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@enthusiastmartin enthusiastmartin mentioned this pull request Mar 30, 2023
@Roznovjak
Copy link
Collaborator

Closing in favor of #194

@Roznovjak Roznovjak closed this Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants