Skip to content

Conversation

@DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Nov 25, 2025

What this PR does / why we need it:
Fix logging error for health check.

Observed panic:

{"level":"dpanic","ts":"2025-11-25T10:33:53.930Z","logger":"aws-custom-route-controller.controller.node","msg":"odd number of arguments passed as key-value pairs for logging","ignored key":"initialise not started","stacktrace":"github.com/gardener/aws-custom-route-controller/pkg/controller.(*NodeReconciler).HealthzChecker\n\t/build/pkg/controller/reconciler.go:175\nsigs.k8s.io/controller-runtime/pkg/healthz.(*Handler).serveAggregated\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/healthz/healthz.go:59\nsigs.k8s.io/controller-runtime/pkg/healthz.(*Handler).ServeHTTP\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/healthz/healthz.go:148\nsigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).addHealthProbeServer.StripPrefix.func3\n\t/usr/local/go/src/net/http/server.go:2384\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2322\nnet/http.(*ServeMux).ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2861\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:3340\nnet/http.(*conn).serve\n\t/usr/local/go/src/net/http/server.go:2109"}

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix logging error for health check.

@DockToFuture DockToFuture requested a review from a team as a code owner November 25, 2025 11:06
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2025
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 25, 2025
@domdom82
Copy link

/lgtm

/approve

@gardener-robot
Copy link

@domdom82 Command /approve is not known.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Nov 25, 2025
@DockToFuture DockToFuture merged commit fa926ac into gardener:main Nov 25, 2025
11 checks passed
@DockToFuture DockToFuture deleted the fix/logging branch November 25, 2025 12:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed/lgtm Has approval for merging size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants