update to sdk-v2 #48
Merged
update to sdk-v2 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
Contributor
Author
MartinWeindel
requested changes
Nov 13, 2024
Member
MartinWeindel
left a comment
MartinWeindel
left a comment
There was a problem hiding this comment.
Thanks!
Looks good to me overall. Only one small change request to get rid of the old AWS sdk dependency.
go.mod
Outdated
| go 1.23.0 | ||
|
|
||
| require ( | ||
| github.com/aws/aws-sdk-go v1.55.5 |
Member
There was a problem hiding this comment.
Not needed anymore.
Suggested change
| github.com/aws/aws-sdk-go v1.55.5 |
Contributor
Author
There was a problem hiding this comment.
Must have missed something. Lemme check again
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
AndreasBurger
approved these changes
Nov 14, 2024
pkg/updater/ec2.go
Outdated
| for _, tag := range tags { | ||
| if aws.StringValue(tag.Key) == "Name" { | ||
| return aws.StringValue(tag.Value) | ||
| if ptr.Deref(tag.Key, "") == "Name" { |
Member
There was a problem hiding this comment.
You could also use aws.ToString(), up to you.
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
MartinWeindel
added
reviewed/ok-to-test
ghost
added
needs/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #46
Special notes for your reviewer:
Release note: