Try all route update ops before returning errors #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
ScheererJ
approved these changes
Jan 10, 2023
Member
ScheererJ
left a comment
ScheererJ
left a comment
There was a problem hiding this comment.
Looks good, just a minor nit.
MartinWeindel
force-pushed
the
improv/update-all-before-returning-errs
branch
from
2d8865b to
a4a297b
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
MartinWeindel
added
reviewed/ok-to-test
ghost
added
needs/ok-to-test
gardener-robot
added
the
status/closed
MartinWeindel
added a commit
that referenced
this pull request
Jan 30, 2023
…g-errs Try all route update ops before returning errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To reduce the impact of a failed route deletion or creation operation, all route updates are executed, even if any of them fails.
In this way, new routes are added even if a deletion fails (which should not happen, but have already been seen).
It should slightly improve robustness, but will not resolve any problem if the route of a deleted node cannot be deleted and its pod CIDR is reused by a new node.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
/cc @kon-angelo