Skip to content

fix broken param in ccm for k8s <= 1.30 #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kon-angelo merged 1 commit into from
Mar 6, 2025
Merged

fix broken param in ccm for k8s <= 1.30 #991

kon-angelo merged 1 commit into from
Mar 6, 2025

Conversation

@kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Mar 6, 2025

How to categorize this PR?

/area control-plane
/kind bug
/platform gcp

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kon-angelo kon-angelo requested review from a team as code owners March 6, 2025 16:21
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/gcp Google cloud platform/infrastructure size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 6, 2025
ScheererJ
ScheererJ approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 6, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 6, 2025
@kon-angelo kon-angelo added this to the v1.43 milestone Mar 6, 2025
@kon-angelo kon-angelo removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 6, 2025
@kon-angelo kon-angelo merged commit 8c0a86b into gardener:master Mar 6, 2025
8 of 20 checks passed
@kon-angelo kon-angelo deleted the fix-ccm-chart-1.30 branch March 6, 2025 16:31
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 6, 2025
@ialidzhikov ialidzhikov mentioned this pull request Mar 7, 2025
Closed
@gardener-github-actions gardener-github-actions bot mentioned this pull request Oct 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees

No one assigned

Labels

area/control-plane Control plane related kind/bug Bug platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

v1.43

Development

Successfully merging this pull request may close these issues.

5 participants

@kon-angelo @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot