Skip to content

Log rollout events #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronfern merged 1 commit into from
Aug 29, 2025
Merged

Log rollout events #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/controller/deployment_inplace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ func (dc *controller) rolloutInPlace(ctx context.Context, d *v1alpha1.MachineDep
// status-rollout steps.
if dc.autoscalerScaleDownAnnotationDuringRollout {
// Annotate all the nodes under this machine-deployment, as roll-out is on-going.
klog.V(3).Infof("RolloutInPlace ongoing for MachineDeployment %q, annotating all nodes under it with %s", d.Name, clusterAutoscalerScaleDownAnnotations)
err := dc.annotateNodesBackingMachineSets(ctx, allMachineSets, clusterAutoscalerScaleDownAnnotations)
if err != nil {
klog.Errorf("failed to add annotations %s on all nodes. Error: %v", clusterAutoscalerScaleDownAnnotations, err)
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/deployment_recreate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func (dc *controller) rolloutRecreate(ctx context.Context, d *v1alpha1.MachineDe
// status-rollout steps.
if len(oldISs) > 0 && !dc.machineSetsScaledToZero(oldISs) {
// Annotate all the nodes under this machine-deployment, as roll-out is on-going.
klog.V(3).Infof("RolloutRecreate ongoing for MachineDeployment %q, annotating all nodes under it with %s", d.Name, clusterAutoscalerScaleDownAnnotations)
err := dc.annotateNodesBackingMachineSets(ctx, allISs, clusterAutoscalerScaleDownAnnotations)
if err != nil {
klog.Errorf("Failed to add %s on all nodes. Error: %s", clusterAutoscalerScaleDownAnnotations, err)
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/deployment_rolling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func (dc *controller) rolloutRolling(ctx context.Context, d *v1alpha1.MachineDep
// status-rollout steps.
if len(oldISs) > 0 && !dc.machineSetsScaledToZero(oldISs) {
// Annotate all the nodes under this machine-deployment, as roll-out is on-going.
klog.V(3).Infof("RolloutRolling ongoing for MachineDeployment %q, annotating all nodes under it with %s", d.Name, clusterAutoscalerScaleDownAnnotations)
err := dc.annotateNodesBackingMachineSets(ctx, allISs, clusterAutoscalerScaleDownAnnotations)
if err != nil {
klog.Errorf("Failed to add %s on all nodes. Error: %s", clusterAutoscalerScaleDownAnnotations, err)
Expand Down