[GEP-28] Fix panic if provider does not support Driver.InitializeMachine #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/bug
Contributor
|
Thank you @maboehm for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
aaronfern
pushed a commit
to aaronfern/machine-controller-manager
that referenced
this pull request
Oct 24, 2025
aaronfern
added a commit
that referenced
this pull request
Oct 24, 2025
… (#1047) Co-authored-by: Marcel Boehm <[email protected]>
jamand
pushed a commit
to stackitcloud/machine-controller-manager
that referenced
this pull request
Oct 27, 2025
…ener#1032) (gardener#1047) Co-authored-by: Marcel Boehm <[email protected]>
timebertt
pushed a commit
to stackitcloud/machine-controller-manager
that referenced
this pull request
Oct 28, 2025
…ener#1032) (gardener#1047) Co-authored-by: Marcel Boehm <[email protected]>
afritzler
pushed a commit
to afritzler/machine-controller-manager
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/kind bug
Fixes a small bug introduced in #1012, where a panic can occur if the provider does not implement the
InitializeMachinefunction. This code path can only be reached when running without a target-client (gardenadmscenario)Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note: