Skip to content

Conversation

@maekawataiki
Copy link

@maekawataiki maekawataiki commented Jul 5, 2020

Description

This PR addresses the feature request in #25532
It provides better Chinese/Japanese character timeToRead heuristics for gatsby-plugin-mdx

The heuristics are based on another PR #21312 which addresses same issue in gatsby-transformer-remark.

@maekawataiki maekawataiki requested a review from a team July 5, 2020 02:28
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 5, 2020
@LekoArts LekoArts added topic: MDX type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 6, 2020
@KyleAMathews
Copy link
Contributor

Hi sorry for the slow feedback on your PR.

It looks good based on a casual comparison to the plugin-remark PR — one thing that'd make sure this is working (and continues to work) is a new test. Could you add one similar to what's in plugin-remark that tests measuring timeToRead in both english & Chinese & Japanese?

@LekoArts LekoArts added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed topic: MDX labels May 28, 2021
@samajammin
Copy link
Contributor

Hey folks! Any update on this? Would be great to have this support for Japanese & Chinese 😄

@imjoshin
Copy link
Contributor

Hey! Thanks so much for opening this pull request!

Sadly this PR got stale and didn't have any activity for some time. We're trying to do better with PR reviews! To get a better overview of all actionable PRs we're going through all open PRs and triage them. Since we won't be able to do everything and adding new features always means added maintenance burden, we have to be more picky about what's beneficial for the average user and the project itself longterm.

We think this is a great PR and would love to see it land in Gatsby. We're closing this PR for now but if you're able to rebase onto the latest master branch and try it out with the latest next versions, we'd be happy to review the PR when its re-opened.

One thing to note is we have a new major version of the MDX plugin coming soon, see the discussion and milestone. Due to the timing, I would recommend a PR against v2 and using that when it launches. 😄

We absolutely want to have you as a contributor and are sorry for any inconveniences we caused with replying too late to this PR.

Thanks for submitting to Gatsby! 💜

@imjoshin imjoshin closed this Jul 25, 2022
@LekoArts
Copy link
Contributor

Note: The new version of gatsby-plugin-mdx no longer has a timeToRead or wordCount field so you can create this yourself now with accurate information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: remark/mdx Related to Markdown, remark & MDX ecosystem type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants