Fix escaping fzf query #60
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when trying to get fzf completion for directories that had backslashes to escape characters, it wouldn't work.
string trimonly removes the backslashes from the beginning and the end of the string, not the middle (which it didn't even do because the correct syntax is'\\', not'\'').Fish has the command
string unescape, seems to be the correct one for this context.In commit cfe17fb, the variable
fifc_fzf_querychanges tofifc_queryin its declaration and infzf_cmd, but not in this line:fifc/functions/_fifc.fish
Line 29 in cfe17fb
which means the trim stopped applying.