plot_orientation: support directed graph bearings#1139
Merged
Conversation
dhimmel
commented
Mar 3, 2024
b5c56a0 to
ee3d63d
Compare
gboeing
requested changes
Mar 3, 2024
Owner
gboeing
left a comment
There was a problem hiding this comment.
Thanks, looking good. Just a few comments.
07613cc to
a0a86dc
Compare
a0a86dc to
32ed03f
Compare
Contributor
Author
|
@gboeing looks like I need another workflow approval. If the test passes then this PR is good on my end absent any additional suggestions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #1139 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 25 25
Lines 2428 2433 +5
=======================================
+ Hits 2380 2385 +5
Misses 48 48 ☔ View full report in Codecov by Sentry. |
gboeing
approved these changes
Mar 6, 2024
Owner
|
The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1137
for v2 / #1106
TODOs:
orientation_entropy