Skip to content

plot_orientation: support directed graph bearings#1139

Merged
gboeing merged 6 commits into
gboeing:v2from
dhimmel:dhimmel-directional-bearings
Mar 6, 2024
Merged

plot_orientation: support directed graph bearings#1139
gboeing merged 6 commits into
gboeing:v2from
dhimmel:dhimmel-directional-bearings

Conversation

@dhimmel
Copy link
Copy Markdown
Contributor

@dhimmel dhimmel commented Mar 3, 2024

closes #1137
for v2 / #1106

TODOs:

  • update changelog
  • add tests / code example
  • consider directed bearing support in orientation_entropy
  • ensure tests passing on CI (workflow approval required)

Comment thread osmnx/plot.py Outdated
@dhimmel dhimmel force-pushed the dhimmel-directional-bearings branch from b5c56a0 to ee3d63d Compare March 3, 2024 15:51
Copy link
Copy Markdown
Owner

@gboeing gboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good. Just a few comments.

Comment thread osmnx/bearing.py Outdated
Comment thread osmnx/bearing.py Outdated
Comment thread osmnx/bearing.py Outdated
Comment thread osmnx/plot.py Outdated
Comment thread tests/test_osmnx.py Outdated
Comment thread tests/test_osmnx.py
@dhimmel dhimmel force-pushed the dhimmel-directional-bearings branch from 07613cc to a0a86dc Compare March 4, 2024 02:34
@dhimmel dhimmel force-pushed the dhimmel-directional-bearings branch from a0a86dc to 32ed03f Compare March 4, 2024 02:35
@dhimmel dhimmel marked this pull request as ready for review March 4, 2024 02:40
@dhimmel
Copy link
Copy Markdown
Contributor Author

dhimmel commented Mar 4, 2024

@gboeing looks like I need another workflow approval. If the test passes then this PR is good on my end absent any additional suggestions.

@dhimmel
Copy link
Copy Markdown
Contributor Author

dhimmel commented Mar 4, 2024

hoping 9cb9c99 will fix test.

unrelated to PR, when min_length=0, it might make sense to skip the data["length"] such that setting length is not required:

if u != v and data["length"] >= min_length:

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (ca9744b) to head (9cb9c99).

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1139   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          25       25           
  Lines        2428     2433    +5     
=======================================
+ Hits         2380     2385    +5     
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhimmel dhimmel requested a review from gboeing March 4, 2024 13:26
@gboeing gboeing merged commit bc0a9bc into gboeing:v2 Mar 6, 2024
@dhimmel dhimmel deleted the dhimmel-directional-bearings branch March 6, 2024 19:05
gboeing added a commit that referenced this pull request Mar 6, 2024
@gboeing gboeing mentioned this pull request Mar 13, 2024
13 tasks
@gboeing
Copy link
Copy Markdown
Owner

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants