Skip to content

_bearings_distribution: defer weighting to np.histogram#1147

Merged
gboeing merged 6 commits into
gboeing:v2from
dhimmel:dsh-issue-1143
Mar 16, 2024
Merged

_bearings_distribution: defer weighting to np.histogram#1147
gboeing merged 6 commits into
gboeing:v2from
dhimmel:dsh-issue-1143

Conversation

@dhimmel
Copy link
Copy Markdown
Contributor

@dhimmel dhimmel commented Mar 13, 2024

closes #1143

TODO:

  • pass CI

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (12dbb6c) to head (6ca5352).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1147   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          24       24           
  Lines        2432     2436    +4     
=======================================
+ Hits         2383     2387    +4     
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhimmel dhimmel marked this pull request as ready for review March 13, 2024 02:30
Copy link
Copy Markdown
Owner

@gboeing gboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhimmel looks good. Just one comment to simplify a bit of the code.

Comment thread osmnx/bearing.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants