Skip to content

Record: optimise filterWithIndex (conservative) and traverseWithKey (less object creations) (fixes #711) #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcanti merged 8 commits into from
Feb 11, 2019
Merged

Record: optimise filterWithIndex (conservative) and traverseWithKey (less object creations) (fixes #711) #725

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea5cd7a
filterWithIndex is conservative
sledorze Feb 10, 2019
fe11e13
try to trigger all code path for Record filter
sledorze Feb 10, 2019
3845e71
try to trigger all code path for Record filter
sledorze Feb 10, 2019
dfa09d5
optimize Record
sledorze Feb 10, 2019
d2e03b1
R.traverseWithKey returns empty without entries
sledorze Feb 10, 2019
87987b1
use simpler implementation for record filterWithIndex
sledorze Feb 11, 2019
e960564
remove useless test
sledorze Feb 11, 2019
35ce4e4
fix coverage
sledorze Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try to trigger all code path for Record filter
  • Loading branch information
@sledorze
sledorze committed Feb 10, 2019
commit fe11e1339a02b9f1dc1ca80d851b57ca08894f53
4 changes: 4 additions & 0 deletions test/Record.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ describe('Record', () => {
const actual = R.filter(y, isNumber)
assert.deepStrictEqual(actual, { a: 1 })

const z: Record<string, string | number> = { b: 1, a: 'foo' }
const actual2 = R.filter(z, isNumber)
assert.deepStrictEqual(actual2, { b: 1 })

assert.strictEqual(R.filter(y, _ => true), y)
})

Expand Down