Skip to content

feat: should not show date if it is empty #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CatWithApple merged 1 commit into from
Mar 28, 2019
Merged

feat: should not show date if it is empty #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/static/components/summary/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,25 @@ class Summary extends Component {
skipped: PropTypes.number.isRequired,
retries: PropTypes.number.isRequired
}),
date: PropTypes.string.isRequired
date: PropTypes.string
}

render() {
const {date} = this.props;
const {total, passed, failed, skipped, retries} = this.props.stats;

const dateBlock = date
? <div className='summary__date'>created at {date}</div>
: null;

return (
<dl className="summary">
<SummaryKey label="Total Tests" value={total}/>
<SummaryKey label="Passed" value={passed}/>
<SummaryKey label="Failed" value={failed} isFailed={true}/>
<SummaryKey label="Skipped" value={skipped}/>
<SummaryKey label="Retries" value={retries}/>
<div className='summary__date'>created at {date}</div>
{dateBlock}
</dl>
);
}
Expand Down