Skip to content

[ENH] Refactor mesh extraction and add scalar field at interface to structural elements | | GEN-12031 #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025
Merged

[ENH] Refactor mesh extraction and add scalar field at interface to structural elements | | GEN-12031 #1019

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94257e4
[TEST] Adding asserts to marching cubes test
Leguark May 1, 2025
07c88cd
[ENH/CLN] Adding scalar_field_value at interface to StructuralElement
Leguark May 1, 2025
fd3ce56
[ENH] Refactor marching cubes mesh extraction logic
Leguark May 1, 2025
95a82f3
[TEST] Enable image generation in marching cubes test
Leguark May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[TEST] Adding asserts to marching cubes test
  • Loading branch information
@Leguark
Leguark committed May 2, 2025
commit 94257e4a5e3aacbb8eb9e3ea3c78534c1eaf7abc
10 changes: 9 additions & 1 deletion test/test_modules/test_marching_cubes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,20 @@ def test_marching_cubes_implementation():
# assert arrays.scalar_field_matrix.shape == (3, 8_000) # * 3 surfaces, 8000 points

marching_cubes.set_meshes_with_marching_cubes(model)

# Assert
assert model.solutions.block_solution_type == RawArraysSolution.BlockSolutionType.DENSE_GRID
assert model.solutions.dc_meshes is None
assert model.structural_frame.structural_groups[0].elements[0].vertices.shape == (600, 3)
assert model.structural_frame.structural_groups[1].elements[0].vertices.shape == (860, 3)
assert model.structural_frame.structural_groups[2].elements[0].vertices.shape == (1_256, 3)
assert model.structural_frame.structural_groups[2].elements[1].vertices.shape == (1_680, 3)

if PLOT:
gpv = require_gempy_viewer()
gtv: gpv.GemPyToVista = gpv.plot_3d(
model=model,
show_data=True,
image=False,
image=True,
show=True
)