[ENH] Replace InterpolationOptions constructor with from_args method for serialization #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Replaced direct instantiation of `InterpolationOptions` with the `from_args` class method across multiple modules and tests for consistency and improved clarity. Updated related examples and fixtures to align with this change.
Added validation logic for `kernel_function` fields to ensure proper deserialization from string inputs to enums. Enhanced default JSON serialization by including additional encoders and adjusted relevant field exclusions.
4 tasks
Upgraded gempy_engine dependency to the latest version for improved functionality and bug fixes. Ensure compatibility by updating local environments accordingly.
Leguark
changed the title
Contributor
Graphite Automations"Add gempy label" took an action on this PR • (05/14/25)1 label was added to this PR based on Miguel de la Varga's automation. |
Relax version constraints to include development versions. This ensures compatibility with the latest updates while avoiding breaking changes in the next major release.
Member
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
InterpolationOptionsconstructor to use a factory methodfrom_args()instead of direct instantiation. This change affects multiple files whereInterpolationOptionswas being created directly. Added a new test filetest_serialize_model.pyto verify serialization and deserialization ofInterpolationOptionsobjects. Also expanded the development log with detailed notes about model saving requirements.Relates to #serialization-support
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).