Skip to content

Conversation

@javoha
Copy link
Member

@javoha javoha commented May 19, 2025

Description

Uploaded the new onlap example for the video tutorial series.

Relates to

Checklist

  • My code uses type hinting for function and method arguments and return values.
  • I have created tests which cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New tests pass locally with my changes.

@graphite-app graphite-app bot added the gempy 3 Will come with the next major update label May 19, 2025
@javoha
Copy link
Member Author

javoha commented May 19, 2025

Hi @Leguark,

so far I only added the example exactly the same way as the others under \examples\tutorials\z_other_tutorials.
Do I need to do anything else for you to integrate it in the documentation on gempy.org?

@graphite-app
Copy link

graphite-app bot commented May 19, 2025

Graphite Automations

"Add gempy label" took an action on this PR • (05/19/25)

1 label was added to this PR based on Miguel de la Varga's automation.

Copy link
Member

Leguark commented May 20, 2025

I will trigger a doc build

@Leguark
Copy link
Member

Leguark commented May 21, 2025

Okay, it took me a while because I had 2 examples broken in main. So now:

  1. in All Checks passed you can see the build the docs check and with you auth from team city you should be able to see the build.
  2. Under the artifact tab you should be able to find the html files. You can download the zip and open it in your computer to see the full docs or you can just find the html of the new tutorial (I already checked that it is there).
    3a. If you are happy with the result we just merge this into main
    3b. If you are unhappy push the change and we build again
  3. Once in main, we just need to tag the build as published and run another workflow to put it online

@javoha
Copy link
Member Author

javoha commented May 22, 2025

Okay, it took me a while because I had 2 examples broken in main. So now:

  1. in All Checks passed you can see the build the docs check and with you auth from team city you should be able to see the build.
  2. Under the artifact tab you should be able to find the html files. You can download the zip and open it in your computer to see the full docs or you can just find the html of the new tutorial (I already checked that it is there).
    3a. If you are happy with the result we just merge this into main
    3b. If you are unhappy push the change and we build again
  3. Once in main, we just need to tag the build as published and run another workflow to put it online

Great and thanks for the walk through. It all worked exactly as you said and looks good - will merge now.

@javoha
Copy link
Member Author

javoha commented May 22, 2025

@Leguark: It tells me I can't merge due to rule violations - but I think I cant see which rules I am violating. Do you have any idea?

Copy link
Member

Leguark commented May 23, 2025

Err maybe is my approval

Copy link
Member

@Leguark Leguark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Leguark Leguark merged commit faf1a41 into main May 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gempy 3 Will come with the next major update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants