-
-
Notifications
You must be signed in to change notification settings - Fork 262
Compute at compuation time #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… compute_at_compuation_time
Graphite Automations"Add gempy label" took an action on this PR • (06/12/25)1 label was added to this PR based on Miguel de la Varga's automation. |
|
So yeah two small bugs but that it was messing up computations times:
These two things are mostly patches for gempy_engine. I will do a pre-release as soon as the CI ends |
That's great to hear, thanks a lot for looking into it! |
Modified the approved test file to set `compute_scalar_gradient` to `false`, ensuring consistency with test expectations and configuration.
Description
New PR for the evaluating the computation time for custom grids. Test now includes model computation for pure model, after adding a topography and using the
compute_model_atfunction with 1000 random points.I removed the test that deep created to clean up.
Just fyi - here are the resulting times on my computer:
Added a warning message to
compute_model_atfunction to alert users about potential side effects when setting a custom grid and computing the model. Modified theset_custom_gridfunction to include aresetparameter, which is now set toTrueincompute_model_atto ensure proper grid reset.Removed code in the
solutionssetter that was setting solutions per group, as this was causing issues with the custom grid functionality.Added comprehensive tests to measure and compare computation times across different grid configurations:
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
Relates to: gempy-project/gempy_engine#16 (comment)