Skip to content

Thumbnails and partial num search #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Thumbnails and partial num search #1

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0deb320
expose thumbnail bool; partial num search
DT-1236 Jun 19, 2019
f2113cd
use gotos; directly build array instead of mutate
DT-1236 Jul 18, 2019
475cf9c
remove yarn lock
DT-1236 Jul 18, 2019
61c4d44
merge master
DT-1236 Jul 25, 2019
b40b975
use static and dispatch_once
DT-1236 Jul 25, 2019
9ac33e5
change a goto label name
DT-1236 Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
change a goto label name
  • Loading branch information
@DT-1236
DT-1236 committed Jul 25, 2019
commit 9ac33e562a2c47eab2ae141cd56b97fa6b65e4ba
6 changes: 3 additions & 3 deletions ios/RCTContacts/RCTContacts.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ -(void) getContactsFromAddressBook:(CNContactStore *)store
}

for (NSString *term in searchTerms) {
// nextTerm: continues to the next term in searchTerms; incompleteMatch: skips adding contact to results
// nextTerm: continues to the next term in searchTerms; skipToNextContact: skips adding contact to results
for (NSString *name in names) {
if ([name rangeOfString:term options:(NSAnchoredSearch | NSCaseInsensitiveSearch)].location != NSNotFound) {
goto nextTerm;
Expand All @@ -172,12 +172,12 @@ -(void) getContactsFromAddressBook:(CNContactStore *)store
}
}
}
goto incompleteMatch;
goto skipToNextContact;
nextTerm:;
}

[contacts addObject:[self contactToDictionary:contact withThumbnails:YES]];
incompleteMatch:;
skipToNextContact:;
}];

callback(@[[NSNull null], contacts]);
Expand Down