Skip to content

Catch missing configuration row for external choices #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grzesiek2010 merged 5 commits into from
Nov 20, 2025
Merged

Catch missing configuration row for external choices #6794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9e13d4
Add new test to cober mixing external and internal choices
grzesiek2010 Sep 26, 2025
9643683
Add a failing test to cover the case with missing confirg row
grzesiek2010 Sep 26, 2025
376f1f6
Catch missing configuration row for external choices
grzesiek2010 Sep 26, 2025
5da8cfe
Fix the code searching for the config row
grzesiek2010 Oct 15, 2025
dea0839
Make test more realistic
grzesiek2010 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a failing test to cover the case with missing confirg row
  • Loading branch information
@grzesiek2010
grzesiek2010 committed Sep 26, 2025
commit 9643683991e9f75bd4016b081b80435cb6398b8a
11 changes: 11 additions & 0 deletions ...app/src/androidTest/java/org/odk/collect/android/feature/formentry/ExternalSelectsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,15 @@ class ExternalSelectsTest {
.startBlankForm("dynamic_and_static_choices")
.assertTexts("Mango", "Oranges", "Strawberries", "Apples")
}

@Test
fun missingFileMessage_shouldBeDisplayedIfDynamicChoicesUsedButTheConfigurationRowIsMissing() {
val formsDirPath = StoragePathProvider().getOdkDirPath(StorageSubdirectory.FORMS)

rule.startAtMainMenu()
.copyForm("dynamic_and_static_choices.xml", listOf("fruits.csv"))
.startBlankForm("dynamic_and_static_choices")
.swipeToNextQuestion("Choose a number")
.assertText("File: $formsDirPath/dynamic_and_static_choices-media/numbers.csv is missing.")
}
}
13 changes: 13 additions & 0 deletions test-forms/src/main/resources/forms/dynamic_and_static_choices.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
<instance>
<data id="dynamic_and_static_choices">
<fruits/>
<numbers/>
<meta>
<instanceID/>
</meta>
</data>
</instance>
<bind nodeset="/data/fruits" type="string"/>
<bind nodeset="/data/numbers" type="string"/>
<bind nodeset="/data/meta/instanceID" type="string" readonly="true()" jr:preload="uid"/>
</model>
</h:head>
Expand All @@ -34,5 +36,16 @@
<value>0</value>
</item>
</select1>
<select1 ref="/data/numbers" appearance="search('numbers')">
<label>Choose a number</label>
<item>
<label>0</label>
<value>0</value>
</item>
<item>
<label>1</label>
<value>1</value>
</item>
</select1>
</h:body>
</h:html>