Skip to content

Add experimental opt-in for entities spec v2025.1 #6930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seadowg merged 5 commits into from
Oct 17, 2025
Merged

Add experimental opt-in for entities spec v2025.1 #6930

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2924e57
Convert EntityXFormParserFactory to kotlin
grzesiek2010 Oct 12, 2025
1d4122b
Add experimental opt-in for entities spec v2025.1
grzesiek2010 Oct 12, 2025
a21def1
Fix existing tests
grzesiek2010 Oct 14, 2025
3fd8aae
Add new tests
grzesiek2010 Oct 14, 2025
01f5dc5
Use getExperimentalOptIn to determine if the spec is enabled
grzesiek2010 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use getExperimentalOptIn to determine if the spec is enabled
  • Loading branch information
@grzesiek2010
grzesiek2010 committed Oct 16, 2025
commit 01f5dc57a3221ffd69534b2da3fb63ab5fd8da72
3 changes: 2 additions & 1 deletion ...p/src/main/java/org/odk/collect/android/application/initialization/JavaRosaInitializer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import org.javarosa.xform.parse.XFormParserFactory
import org.javarosa.xform.util.XFormUtils
import org.odk.collect.android.dynamicpreload.DynamicPreloadXFormParserFactory
import org.odk.collect.android.logic.actions.setgeopoint.CollectSetGeopointActionHandler
import org.odk.collect.android.preferences.SettingsExt.getExperimentalOptIn
import org.odk.collect.android.projects.ProjectsDataService
import org.odk.collect.entities.javarosa.intance.LocalEntitiesExternalInstanceParserFactory
import org.odk.collect.entities.javarosa.parse.EntityXFormParserFactory
Expand Down Expand Up @@ -46,7 +47,7 @@ class JavaRosaInitializer(
val entityXFormParserFactory =
EntityXFormParserFactory(
XFormParserFactory()
) { settingsProvider.getUnprotectedSettings().getBoolean(ProjectKeys.KEY_ENTITIES_SPEC_V2025_1) }
) { settingsProvider.getUnprotectedSettings().getExperimentalOptIn(ProjectKeys.KEY_ENTITIES_SPEC_V2025_1) }
val dynamicPreloadXFormParserFactory =
DynamicPreloadXFormParserFactory(entityXFormParserFactory)

Expand Down