Skip to content

Optimize build_instrumented job #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grzesiek2010 merged 13 commits into from
Nov 4, 2025
Merged

Optimize build_instrumented job #6954

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c379ee9
Remove unneeded gradle task
seadowg Nov 3, 2025
7c988d1
Upgrade machines with appropriate Gradle configs
seadowg Nov 3, 2025
828f5ee
Correct resource name
seadowg Nov 3, 2025
c06dbf1
Only persist APKs from build_instrumented
seadowg Nov 3, 2025
a001917
Correct APK size
seadowg Nov 3, 2025
107eacf
Simplify caching
seadowg Nov 4, 2025
3ef66a4
Correct cache key path
seadowg Nov 4, 2025
1377083
Increase heap size for what's available in large config
seadowg Nov 4, 2025
f3d1741
Use caching instead of workspace for speeding up builds
seadowg Nov 4, 2025
afe01ee
Correct environment reference
seadowg Nov 4, 2025
28ea21e
Increase default gradle config
seadowg Nov 4, 2025
143de12
Cache gradle wrapper as well
seadowg Nov 4, 2025
9c193f0
Don't run CI for PRs without approval
seadowg Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't run CI for PRs without approval
  • Loading branch information
@seadowg
seadowg committed Nov 4, 2025
commit 9c193f0ae903fb08c9e83e94b3d24301b1347229
19 changes: 18 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,24 @@ workflows:
version: 2
commit:
jobs:
- compile
- hold_pr:
Copy link
Copy Markdown
Member Author

@seadowg seadowg Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I often find that I might be committing/pushing quickly and that context, CI will be constantly starting and cancelling workflow runs. Add a manual approval step means we only end up running jobs when we actually care about the result. I'd like to try this, but definitely let me know if you feel like it's getting annoying @grzesiek2010.

Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your rationale, but isn’t it possible to differentiate between draft and ready-for-review PRs and trigger jobs only for those that are ready for review?

Copy link
Copy Markdown
Member Author

@seadowg seadowg Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! It looks like this might be possible with the new Github triggers, but I'm not sure that we'd be able to have it always run for non-drafts and optionally for drafts (you still probably want CI on request for drafts). We could always just use the GitHub API (probably through gh).

I think that's probably a future improvement though: I think we either go with the basic version as-is or remove the hold_pr check for now.

type: approval
filters:
branches:
ignore:
- master
- compile:
filters:
branches:
only:
- master
- compile:
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have two jobs with the same name (compile)? Does it work or one replaces the other?

Copy link
Copy Markdown
Member Author

@seadowg seadowg Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They both reference the compile job definition - this isn't declaring the job. One runs on master only and the other only on non-master.

requires:
- hold_pr
filters:
branches:
ignore:
- master
- check_quality:
requires:
- compile
Expand Down