Skip to content

Only detect exact collinear intersections in traces #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grzesiek2010 merged 5 commits into from
Dec 3, 2025
Merged

Only detect exact collinear intersections in traces #6980

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2928232
Allow passing epsilon in intersection detection
seadowg Dec 1, 2025
5e39d4b
Improve adding random intersection to avoid flakey reversed lines
seadowg Dec 1, 2025
e6474c0
Clean up metamorphic test with helpers
seadowg Dec 1, 2025
472058e
Make closed traces intersecting as well
seadowg Dec 2, 2025
74a6464
Add docs for Trace.addRandomIntersectingSegment
seadowg Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make closed traces intersecting as well
  • Loading branch information
@seadowg
seadowg committed Dec 2, 2025
commit 472058e1d82a40bf6bbf0591d50a88337183e665
2 changes: 1 addition & 1 deletion shared/src/test/java/org/odk/collect/shared/geometry/GeometryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ class GeometryTest {
)

// Check adding an intersection makes intersects true
if (!intersects && !trace.isClosed()) {
if (!intersects) {
val intersectingTrace = trace.addRandomIntersectingSegment()
assertThat(
"Expected intersects=true:\n$intersectingTrace",
Expand Down