-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Restyle geoshape/geotrace #7017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
736ef94
Change default color for lines in maps
seadowg 36fad66
Simplify MapIconCreator interface
seadowg ecd7772
Add convenience extension for create marker icon bitmaps
seadowg c825cc2
Add new specific icon for line points
seadowg 12b6cd8
Fill center of shapes
seadowg b05cc7a
Make first point in polygon bigger
seadowg 98c9d9b
Fix constructor use in tests
seadowg 71dc983
Update default color tests
seadowg cdc6503
Fix assertions on MarkerIconDescription
seadowg 6a76557
Correct method name
seadowg dff3c30
Update implementations
seadowg 2b6491d
Store line points in GeoPolyFragment instead of in MapFragment
seadowg be829c4
Fix clear behaviour
seadowg b6c1276
Remove unneeded formatting for shape
seadowg 29b7bb3
Switch to using polygons with map for shapes
seadowg 8415fc2
Don't use new API for Google and Mapbox
seadowg 7e585a2
Highlight last point rather than first
seadowg d5f30e7
Remove add/remove methods for poly points
seadowg 3d90579
Store LocationTracker location in Flow
seadowg b45e310
Expose location as StateFlow
seadowg 7d09ee0
Remove unused field
seadowg 0f8d2f2
Use ViewModel for points state
seadowg e576fa6
Use LocationTracker to schedule location recording
seadowg 91b0bea
Fix whitespace issue
seadowg 6ae1adb
Add updatePolyLine method
seadowg d0281d4
Add updatePolygon method
seadowg 2774e36
Simplify feature description constructor calls
seadowg 055f227
Highlight last point with different color
seadowg f3147e3
Update fake
seadowg 3e07038
Clean up unneeded code
seadowg d508feb
Break up single line
seadowg 974898f
Rename method
seadowg a63222a
Rename class
seadowg f3c1845
Remove double save to cache
seadowg 46f0155
Correct whitespace
seadowg 16eabc9
Fix formatting
seadowg 2164907
Correct typo
seadowg 72a978f
Use isNotEmpty
seadowg f6ded2d
Use last()
seadowg 35ae10e
Remove redundant let
seadowg e6d579d
Remove redundant alpha setting
seadowg 0b63d63
Only update map when points updated
seadowg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove redundant let
- Loading branch information
commit 35ae10e437458d7ffe1ee266f2cedf75ef9fac5e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've talked off and on about whether to use coroutines directly like this (as opposed to through our Scheduler interface) - especially with ViewModels as it gives us
viewModelScope. I can't immediately think of a benefit to usingSchedulerhere as this work is dispatched on the UI thread, so there's no need to integrate withIdlingResourcefor Espresso. That said, as far as I can tell, there are no tests for the automatic location recording. I'll backfill those as a follow up and see how this fits in.