Add info button to trace/shape questions #7021
Add tests
- Loading branch information
commit 800e0a2ba3f08be8233a95b3d62115516932ffe3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| package org.odk.collect.geo.geopoly | ||
|
|
||
| import android.app.Application | ||
| import androidx.compose.ui.test.assertIsDisplayed | ||
| import androidx.compose.ui.test.junit4.createComposeRule | ||
| import androidx.compose.ui.test.onNodeWithText | ||
| import androidx.compose.ui.test.performScrollTo | ||
| import androidx.test.core.app.ApplicationProvider | ||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
| import org.junit.Rule | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.mockito.kotlin.mock | ||
| import org.mockito.kotlin.whenever | ||
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| class InfoDialogTest { | ||
grzesiek2010 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| @get:Rule | ||
| val composeTestRule = createComposeRule() | ||
|
|
||
| private val context = ApplicationProvider.getApplicationContext<Application>() | ||
|
|
||
| @Test | ||
| fun `shows dialog content from snackbar in PLACEMENT mode`() { | ||
| val viewModel = mock<GeoPolyViewModel>().apply { | ||
| whenever(recordingMode).thenReturn(GeoPolyViewModel.RecordingMode.PLACEMENT) | ||
| } | ||
|
|
||
| composeTestRule.setContent { | ||
| InfoContent(viewModel, fromSnackbar = true, {}) | ||
| } | ||
|
|
||
| assertInfo( | ||
| listOf( | ||
| org.odk.collect.strings.R.string.long_press_to_move_point_info_item, | ||
| org.odk.collect.strings.R.string.remove_last_point_info_item, | ||
| org.odk.collect.strings.R.string.delete_shape_to_start_over_info_item, | ||
| org.odk.collect.strings.R.string.add_point_info_item, | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `shows dialog content from info button in PLACEMENT mode`() { | ||
| val viewModel = mock<GeoPolyViewModel>().apply { | ||
| whenever(recordingMode).thenReturn(GeoPolyViewModel.RecordingMode.PLACEMENT) | ||
| } | ||
|
|
||
| composeTestRule.setContent { | ||
| InfoContent(viewModel, fromSnackbar = false, {}) | ||
| } | ||
|
|
||
| assertInfo( | ||
| listOf( | ||
| org.odk.collect.strings.R.string.tap_to_add_a_point_info_item, | ||
| org.odk.collect.strings.R.string.long_press_to_move_point_info_item, | ||
| org.odk.collect.strings.R.string.remove_last_point_info_item, | ||
| org.odk.collect.strings.R.string.delete_entire_shape_info_item, | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `shows dialog content from snackbar in MANUAL mode`() { | ||
| val viewModel = mock<GeoPolyViewModel>().apply { | ||
| whenever(recordingMode).thenReturn(GeoPolyViewModel.RecordingMode.MANUAL) | ||
| } | ||
|
|
||
| composeTestRule.setContent { | ||
| InfoContent(viewModel, fromSnackbar = true, {}) | ||
| } | ||
|
|
||
| assertInfo( | ||
| listOf( | ||
| org.odk.collect.strings.R.string.physically_move_to_correct_info_item, | ||
| org.odk.collect.strings.R.string.long_press_to_move_point_info_item, | ||
| org.odk.collect.strings.R.string.remove_last_point_info_item, | ||
| org.odk.collect.strings.R.string.delete_entire_shape_info_item, | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `shows dialog content from info button in MANUAL mode`() { | ||
| val viewModel = mock<GeoPolyViewModel>().apply { | ||
| whenever(recordingMode).thenReturn(GeoPolyViewModel.RecordingMode.MANUAL) | ||
| } | ||
|
|
||
| composeTestRule.setContent { | ||
| InfoContent(viewModel, fromSnackbar = false, {}) | ||
| } | ||
|
|
||
| assertInfo( | ||
| listOf( | ||
| org.odk.collect.strings.R.string.tap_to_add_a_point_info_item, | ||
| org.odk.collect.strings.R.string.physically_move_to_correct_info_item, | ||
| org.odk.collect.strings.R.string.long_press_to_move_point_info_item, | ||
| org.odk.collect.strings.R.string.remove_last_point_info_item, | ||
| org.odk.collect.strings.R.string.delete_entire_shape_info_item, | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `shows dialog content from snackbar in AUTOMATIC mode`() { | ||
| val viewModel = mock<GeoPolyViewModel>().apply { | ||
| whenever(recordingMode).thenReturn(GeoPolyViewModel.RecordingMode.AUTOMATIC) | ||
| } | ||
|
|
||
| composeTestRule.setContent { | ||
| InfoContent(viewModel, fromSnackbar = true, {}) | ||
| } | ||
|
|
||
| assertInfo( | ||
| listOf( | ||
| org.odk.collect.strings.R.string.physically_move_to_correct_info_item, | ||
| org.odk.collect.strings.R.string.long_press_to_move_point_info_item, | ||
| org.odk.collect.strings.R.string.remove_last_point_info_item, | ||
| org.odk.collect.strings.R.string.delete_entire_shape_info_item, | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `shows dialog content from info button in AUTOMATIC mode`() { | ||
| val viewModel = mock<GeoPolyViewModel>().apply { | ||
| whenever(recordingMode).thenReturn(GeoPolyViewModel.RecordingMode.AUTOMATIC) | ||
| } | ||
|
|
||
| composeTestRule.setContent { | ||
| InfoContent(viewModel, fromSnackbar = false, {}) | ||
| } | ||
|
|
||
| assertInfo( | ||
| listOf( | ||
| org.odk.collect.strings.R.string.tap_to_add_a_point_info_item, | ||
| org.odk.collect.strings.R.string.physically_move_to_correct_info_item, | ||
| org.odk.collect.strings.R.string.long_press_to_move_point_info_item, | ||
| org.odk.collect.strings.R.string.remove_last_point_info_item, | ||
| org.odk.collect.strings.R.string.delete_entire_shape_info_item, | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| private fun assertInfo(items: List<Int>) { | ||
| items.forEach { | ||
| composeTestRule | ||
| .onNodeWithText(context.getString(it)) | ||
| .performScrollTo() | ||
| .assertIsDisplayed() | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed? If I take it out, then there's a failure, but it seems completely unrelated to everything else here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens because
androidx.compose.ui:ui-test-manifestprovides its own test manifest, which changes the default app theme used during tests. Robolectric picks up that manifest even for non-Compose tests, and the new default theme is not AppCompat/Material.