Skip to content

Allow adding points inside shapes or on trace lines in Google Maps #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seadowg merged 2 commits into from
Jan 22, 2026
Merged

Allow adding points inside shapes or on trace lines in Google Maps #7044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75140b2
Make dynamic polyline/polygon not clickable
grzesiek2010 Jan 21, 2026
1e2a50b
Fix method name
grzesiek2010 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix method name
  • Loading branch information
@grzesiek2010
grzesiek2010 committed Jan 21, 2026
commit 1e2a50b950f5e6b48fcb8676dc474707a52e6c91
6 changes: 3 additions & 3 deletions google-maps/src/main/java/org/odk/collect/googlemaps/GoogleMapFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ public void update() {
latLngs.add(marker.getPosition());
}
if (markers.isEmpty()) {
clearPolyline();
clearPolygon();
} else if (polygon == null) {
polygon = map.addPolygon(new PolygonOptions()
.strokeColor(polygonDescription.getStrokeColor())
Expand All @@ -1021,7 +1021,7 @@ public void update() {

@Override
public void dispose() {
clearPolyline();
clearPolygon();
for (Marker marker : markers) {
marker.remove();
}
Expand All @@ -1036,7 +1036,7 @@ public List<MapPoint> getPoints() {
return points;
}

private void clearPolyline() {
private void clearPolygon() {
if (polygon != null) {
polygon.remove();
polygon = null;
Expand Down