Skip to content

Reduce duplicate drawing of polylines and polygons + fix feature removing in Google Maps #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grzesiek2010 merged 4 commits into from
Feb 1, 2026
Merged

Reduce duplicate drawing of polylines and polygons + fix feature removing in Google Maps #7065

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b466cc
Move viewData to GeoPolyViewModel
grzesiek2010 Jan 31, 2026
4fd62ed
Avoid emitting duplicate combined LiveData values
grzesiek2010 Jan 31, 2026
2ae024b
Make polygon/polyline invisible bfore removing
grzesiek2010 Jan 31, 2026
280efa3
Fix tests
grzesiek2010 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests
  • Loading branch information
@grzesiek2010
grzesiek2010 committed Jan 31, 2026
commit 280efa3d49161750c64cb1e6ec26ef5e44af9676
4 changes: 4 additions & 0 deletions geo/src/test/java/org/odk/collect/geo/geopoly/GeoPolyViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@ import org.hamcrest.Matchers.equalTo
import org.junit.Rule
import org.junit.Test
import org.mockito.Mockito.mock
import org.odk.collect.androidtest.MainDispatcherRule
import org.odk.collect.testshared.getOrAwaitValue

class GeoPolyViewModelTest {

@get:Rule
val instantTaskExecutorRule = InstantTaskExecutorRule()

@get:Rule
val mainDispatcherRule = MainDispatcherRule()

@Test
fun `#fixedAlerts is null until after invalid message is non-null`() {
val invalidMessage = MutableLiveData<String?>(null)
Expand Down