Correct and simplify branch/tag filtering#7145
Merged
seadowg merged 2 commits intogetodk:v2026.1.xfrom Mar 18, 2026
Merged
Conversation
lognaturel
approved these changes
Mar 18, 2026
lognaturel
reviewed
Mar 18, 2026
.circleci/config.yml
Outdated
| ignore: | ||
| - master | ||
| - ^v((20)[0-9]{2})\.\d+\.x$ | ||
| - /^v\d+\.\d+.x/ |
Member
There was a problem hiding this comment.
Maybe add a $ at the end? Unlikely we'd have a branch name with something after the x but to be really explicit...
lognaturel
approved these changes
Mar 18, 2026
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Mar 19, 2026
Correct and simplify branch/tag filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looked to me like our branch filtering wasn't working correctly and from looking at the config I think we were just missing wrapping our regex in
/(which it seems Circle CI needs). I've also simplified the regex(s) we use here. For double-checking:prshould run for branches that aren'tmasteror hotfix branches (likev123.123.x)masteris the opposite (it runs formasterand hotfix branches)releaseshould run for release tags (likev123.123.123).