Drop legacy cookies and cookie_patterns tables#1186
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
These tables were superseded by tracker_patterns and detected_trackers in migration 20260505T090000Z, which backfilled all data. The old tables are no longer referenced by any Go code, GraphQL schema, MCP specification, or CLI command. The cookie_source and cookie_pattern_match_type enum types are retained because tracker_patterns still uses them. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Émile Ré <nemile.re@gmail.com>
codenem
force-pushed
the
codenem/drop-cookies-cookie-patterns-tables-ad9f
branch
from
c789c24 to
dec767c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a migration to drop the legacy
cookiesandcookie_patternsdatabase tables. These tables were superseded bytracker_patternsanddetected_trackersin migration20260505T090000Z, which backfilled all existing data into the new tables.What changed
20260513T084412Z.sql):DROP TABLE IF EXISTS cookiesfollowed byDROP TABLE IF EXISTS cookie_patternsWhat is preserved
cookie_sourceenum type — still used bytracker_patternsanddetected_trackerscookie_pattern_match_typeenum type — still used bytracker_patternsVerification
cookiesorcookie_patternstablesCookieEntityType) and 88 (CookiePatternEntityType) were already marked as removed inentity_type_reg.goResolves ENG-392
Linear Issue: ENG-392
Summary by cubic
Drops legacy
cookiesandcookie_patternstables via a new migration to clean up the schema now that data lives intracker_patternsanddetected_trackers. Aligns with ENG-392.pkg/coredata/migrations/20260513T084412Z.sqlto dropcookiesandcookie_patterns.cookie_sourceandcookie_pattern_match_typeenums used bytracker_patternsanddetected_trackers.Written for commit dec767c. Summary will update on new commits.