Skip to content

Conversation

@kevinchiang
Copy link
Contributor

@kevinchiang kevinchiang commented Oct 15, 2020

What type of PR is this? (check all applicable)

  • Feature

Description

Many internal endpoints are secured through SSL with an internal certificate authority. By adding the "verify" option to be passed through the request_options, we can allow the requests library to skip SSL certificate verification.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes).

Screen Shot 2020-10-14 at 6 41 30 PM

… the option of skipping certificate verification
@arikfr
Copy link
Member

arikfr commented Oct 20, 2020

Thanks for the PR & for updating the docs 👍

@kravets-levko kravets-levko changed the title Add verify option to JSON datasource runner to allow query developers Add verify option to JSON datasource runner to allow skipping certificate verification Oct 20, 2020
@kravets-levko kravets-levko self-assigned this Oct 20, 2020
michimau pushed a commit to eea/eea.docker.redash-ldap that referenced this pull request Nov 4, 2021
@susodapop
Copy link
Contributor

Closing this PR after merging #5690. Not sure why circleCI wouldn't reset. Thank you so much for this contribution!

@susodapop susodapop closed this Jan 21, 2022
@kevinchiang
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants