Skip to content

Conversation

@mudasirmirza
Copy link

@mudasirmirza mudasirmirza commented Feb 23, 2022

What type of PR is this? (check all applicable)

  • New Query Runner (Data Source)

Description

Adding NewRelic query runner. This support two types of queries, count and comparison.
Added %change in the Counter visualization (as I am not an expert in frontend, I did the best I could)

Related Tickets & Documents

Documentation will be updated on the KB under data sources

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screen Shot 2022-02-23 at 4 35 34 PM

@mudasirmirza
Copy link
Author

@susodapop hey can someone please review and let me know if thing needs to be changed.

@susodapop
Copy link
Contributor

Thanks for the PR @mudasirmirza. Just catching up here so thank you also for the ping.

I'm excited to get suppport for NewRelic merged in. But to keep things isolated, can you please separate your front-end counter visualisation change into a separate PR? It's our policy that each commit to the master branch should be a single change.

Please ping me on both PR's once you're done.

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants