Skip to content

Conversation

@georgewfisher
Copy link

@georgewfisher georgewfisher commented Jul 15, 2022

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Enable Azure AD Oauth login for Redash. Enables a login "with work or school account" option to be configured for the Redash login page which allows the user to authenticate using their Azure/Microsoft work or school identity and generate an associated Redash account.

Implementation is based on Google Oauth code in Redash that already exists. Some consolidation between Google and Azure Oauth code might be possible, but due to need to separate UI, I felt it was cleaner to keep them separate. I have not added RBAC (role-based access control) role verification to this PR but could easily do so (I plan to do this in a future PR).

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Manual testing scope involved local and cloud deployment test setup, test domain configuration, test login, test user account creation, verify user account is functional.

Related Tickets & Documents

getredash/website#658

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Azure AD login using "Microsoft work or school" customer facing langugage:
image

Authentication settings UI under general settings. Shows up only if Azure authentication is enabled.
image

@georgewfisher
Copy link
Author

Looking at test failures

@susodapop susodapop added the Team Review Meets PR criteria, ready for full review label Jul 15, 2022
@susodapop susodapop self-assigned this Jul 15, 2022
@georgewfisher
Copy link
Author

@susodapop Looks like all checks are passing. What do I need to do to get this reviewed? Let me know if you need anything or have any questions!

@susodapop
Copy link
Contributor

Thanks for pinging. My target is to review within two weeks of applying the Team Review 👌

@georgewfisher
Copy link
Author

@susodapop Can you confirm if you are blocked on anything from me? Do I need to do anything to apply to the "Team Review"?

I can also help this process by bringing a 2nd or 3rd set of eyes to supplement your review. Let me know if this would help

@susodapop
Copy link
Contributor

I can also help this process by bringing a 2nd or 3rd set of eyes to supplement your review. Let me know if this would help

Yes absolutely this would help. I appreciate your efforts to get this across the line 🙏

@guidopetri
Copy link
Contributor

@georgewfisher thanks for your contribution! We've made quite a few changes after the switch to community-driven development, would you mind rebasing off of master and resolving merge conflicts so that the CI re-runs?

@guidopetri guidopetri closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Meets PR criteria, ready for full review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants