Update development workflow for Apple Silicon, Node version, default port, and maildev image #5932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2023 23:24
With Node version 19 I stumbled into some issues so for now bumped it to v16, until we get to updating the libraries we use.
1. Switch to newer maildev docker image. 2. Update local port to 5001 as 5000 seems to be used by a system process now.
… way to not install it only on ARM.
gabrieldutra
approved these changes
Mar 23, 2023
Member
gabrieldutra
left a comment
gabrieldutra
left a comment
There was a problem hiding this comment.
Devloop seems to be building on M1, though we probably need to update a few extra docs / files in the next days due to the port change.
I didn't fully test it as I didn't finish setting my Frontend yet 😅
| - redis | ||
| ports: | ||
| - "5000:5000" | ||
| - "5001:5000" |
Member
There was a problem hiding this comment.
Probably want to update this in
Line 37 in fdf636a
Member
Author
There was a problem hiding this comment.
Nice catch. I'll grep the code for 5000.
AkaashK
pushed a commit
to tharzeez/redash
that referenced
this pull request
Jul 18, 2023
…port, and maildev image (getredash#5932) * Update ngines definition to allow for newer versions of Node. With Node version 19 I stumbled into some issues so for now bumped it to v16, until we get to updating the libraries we use. * docker-compose.yml updates: 1. Switch to newer maildev docker image. 2. Update local port to 5001 as 5000 seems to be used by a system process now. * Update pymssql and pyarrow. Also commented out ibm-db until we have a way to not install it only on ARM.
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
…port, and maildev image (getredash#5932) * Update ngines definition to allow for newer versions of Node. With Node version 19 I stumbled into some issues so for now bumped it to v16, until we get to updating the libraries we use. * docker-compose.yml updates: 1. Switch to newer maildev docker image. 2. Update local port to 5001 as 5000 seems to be used by a system process now. * Update pymssql and pyarrow. Also commented out ibm-db until we have a way to not install it only on ARM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a few fixes for the development workflow:
5000to5001as port5000seems to be used by the system on MacOS now.How is this tested?
Related Tickets & Documents
Closes #5805, closes #5804.