Skip to content

Conversation

@naveedc
Copy link

@naveedc naveedc commented Apr 18, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

This is a simple UI feature which allows users to search datasources by name in the datasources tab in settings. When using redash for enterprise purposes the list of datasources can get quite large having a search feature is every helpful.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@naveedc
Copy link
Author

naveedc commented Apr 18, 2024

Screenshot 2024-04-18 at 12 02 56 PM Screenshot 2024-04-18 at 12 00 13 PM

Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naveedc this looks pretty useful, but CI is failing. Can you take a look?

@AndrewChubatiuk
Copy link
Contributor

@naveedc please run yarn prettier. hopefully it'll help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants