python: Show line number when an exception occurs #7264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elro444
force-pushed
the
python-add-exception-line-number
branch
from
9df485a to
4b9cb16
Compare
Contributor
|
I think in case of error line, it would be better to leave it as log only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
When exceptions occurred in queries of the Python data source, you could not see where the error happened.
This PR fixes this and adds the line number where the exception was raised from.
Since the user will care about exceptions in their code, the shown line number will be the "deepest" entry in the stack trace that is from the user's code (from the query).
How is this tested?
Manually added exceptions to my query, and saw that it properly showed the line number of the problematic line.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)