Skip to content

Remove unnecessary global declarations in destination and query #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirkan1 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary global declarations in destination and query #7389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9ba331
Remove unnecessary global declarations in destination and query runne…
mirkan1 Mar 31, 2025
05c76b9
Merge branch 'master' into mirkan1/globals
mirkan1 Mar 31, 2025
83a1152
Add blank lines for improved readability in destination and query run…
mirkan1 May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unnecessary global declarations in destination and query runne… 
…r registration
  • Loading branch information
@mirkan1
mirkan1 committed Mar 31, 2025
commit e9ba331be5c889ac6edf689311b4767dc2b989e0
2 changes: 0 additions & 2 deletions redash/destinations/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ def to_dict(cls):

destinations = {}


def register(destination_class):
global destinations
if destination_class.enabled():
logger.debug(
"Registering %s (%s) destinations.",
Expand Down
2 changes: 0 additions & 2 deletions redash/query_runner/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,7 @@ def get_response(self, url, auth=None, http_method="get", **kwargs):

query_runners = {}


def register(query_runner_class):
global query_runners
if query_runner_class.enabled():
logger.debug(
"Registering %s (%s) query runner.",
Expand Down