ref: Move envelope queueing directly into the endpoint handler #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QueueEnvelopemessage no longer needs to reside on theEnvelopeManagersince #1416. Instead, it has become a simple dispatch function that calls
ProcessMetricsandValidateEnvelopedirectly on the target actors.To skip a redundant message, this PR removes this message entirely and moves its
code into the endpoint handler code. The BufferGuard has moved into utilities.
There is no expected change in behavior or performance, although there could be
a slight decrease in latency since the endpoint no longer has to wait for this
actor.
#skip-changelog