-
-
Notifications
You must be signed in to change notification settings - Fork 6
rfc(feature): Video replay envelope #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
8ccece4
985c32c
7691ba5
26ee3cc
b4d3723
ae41a9d
a653d99
5574b37
14f517b
3c60f03
75aba68
46c72b8
ab3db0d
8843512
c2e004e
e22a091
cb938e5
e9488b1
78987fb
79ef51f
1e20ad4
2424b31
70e1b05
6260eaa
d4dd02a
fc78a2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,15 +30,11 @@ We need this to to capture replays on platforms where it's not possible/feasible | |
| - From the SDK, we would send a new envelope with the following items: `Replay`, `ReplayVideo` and `ReplayRecording`. | ||
| - The newly introduced item type, [`ReplayVideo`](https://github.com/getsentry/relay/blob/5fd3969e88d3eea1f2849e55b61678cac6b14e44/relay-server/src/envelope.rs#L115C5-L115C20) is used to transport the video data. | ||
| The envelope item would consist of a single header line (JSON), followed by a new line and the raw video data. | ||
vaind marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - The header should contain at least the following metadata: | ||
| - The header should contain at least the following metadata: needed to ingest the item. | ||
|
|
||
| ```json | ||
| { | ||
| "segment-id": 4, | ||
|
||
| "size": 3440, | ||
| "duration": 5000, | ||
| "encoding": "whatever", | ||
| "container": "whatever", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -54,16 +50,16 @@ We need this to to capture replays on platforms where it's not possible/feasible | |
| "data": { | ||
| "tag": "video", | ||
| "payload": { | ||
| "segment-id": 4, | ||
| "segmentId": 4, | ||
| "size": 3440, | ||
| "duration": 5000, | ||
| "encoding": "whatever", | ||
| "container": "whatever", | ||
| "height": 1920, | ||
| "width": 1080, | ||
| "frame-count": 50, | ||
| "frame-rate-type": "constant|variable", | ||
| "frame-rate": 10, | ||
| "frameCount": 50, | ||
| "frameRateType": "constant|variable", | ||
| "frameRate": 10, | ||
| } | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billyvg How would the player like to be notified that it should download video data? A
typevalue on the replay? The video events in the RRWeb? Infer it from the replay's platform? Something else?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmanallen Thinking of using the rrweb video event