chore(deps): bump clickhouse to 25.3

[aldy505]

See getsentry/snuba#7361:

We are already running 25.3.6.10034 in s4s and some de clusters

ClickHouse upgrade PR on snuba: getsentry/snuba#7339

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.49%. Comparing base (e3e7789) to head (93550ed).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files           3        3           
  Lines         197      197           
=======================================
  Hits          196      196           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aldy505]

So this works. Next thing is to spin up a relatively "enough" VPS with an old version, and try to upgrade the clickhouse.

[aldy505]

Can confirm this works.

[BYK]

I repeat my plea to make these hard-stops machine-readable somewhere as I think it would help with some other things too.

Thanks for doing this btw!

[aldy505]

I repeat my plea to make these hard-stops machine-readable somewhere as I think it would help with some other things too.

I think it's going to be useful for self-hosted hard stops rather than ClickHouse hard stop, as we only use 2 image tags.

Initially I thought of something like this (pseudocode, bash is a horrible language):

var current_ch_version = (docker compose exec clickhouse clickhouse-client 'select version()')
var ch_stops = ["23.11", "24.8", "24.11", "25.3"]
for (var ch_stop in ch_stops) do
  docker compose build clickhouse $ch_stop
  wait until healthy
  sleep 5s
end

[BYK]

I think it's going to be useful for self-hosted hard stops rather than ClickHouse hard stop, as we only use 2 image tags.

Yeah that's what I meant sorry. That code snippet you shared also looks fine to me.

[aldy505]

I think it's going to be useful for self-hosted hard stops rather than ClickHouse hard stop, as we only use 2 image tags.

Yeah that's what I meant sorry. That code snippet you shared also looks fine to me.

I don't really like bash's for loop. Lets revisit that a bit later

[aldy505]

@aminvakil Hey, can I ask your review on this one, making sure my bash is not wrong.