Skip to content

fix: Provide useful info on permission errors#4096

Merged
BYK merged 1 commit intomasterfrom
byk/fix/better-err-on-permission-err
Dec 9, 2025
Merged

fix: Provide useful info on permission errors#4096
BYK merged 1 commit intomasterfrom
byk/fix/better-err-on-permission-err

Conversation

@BYK
Copy link
Member

@BYK BYK commented Dec 9, 2025

Prevents the very confusing 'Unsupported Docker Architecture' error when we actually had a permission error running docker.

Prevents the very confusing 'Unsupported Docker Architecture' error when we actually had a permission error running docker.
@BYK BYK enabled auto-merge (squash) December 9, 2025 22:21
@BYK BYK requested a review from Dav1dde December 9, 2025 22:21
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically correct info, but I am blind (pls ignore).

I think that should do:

dav1d@colima:xy$ FOO="123"
dav1d@colima:xy$ export FOO
dav1d@colima:xy$ bash
dav1d@colima:xy$ echo $FOO
123
dav1d@colima:xy$ exit
dav1d@colima:xy$ unset FOO
dav1d@colima:xy$ FOO="123"
dav1d@colima:xy$ bash
dav1d@colima:xy$ echo $FOO

dav1d@colima:xy$

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (f9c0c31) to head (2831522).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4096   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files           3        3           
  Lines         207      207           
=======================================
  Hits          206      206           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +28 to +33
if [[ "$DOCKER_ARCH_OUTPUT" == *"permission denied"* ]]; then
echo ""
echo "You may need to add your user to the docker group:"
echo " sudo usermod -aG docker \$USER"
echo "Then log out and log back in, or run: newgrp docker"
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two options from here, actually:

  1. Include yourself into the docker group
  2. Run the install.sh script with sudo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got this auto-merged so happy if you wanna change :D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2. Run the install.sh script with sudo

Let's not suggest bad practices to users :)

@BYK BYK merged commit ce32fe9 into master Dec 9, 2025
16 of 17 checks passed
@BYK BYK deleted the byk/fix/better-err-on-permission-err branch December 9, 2025 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants