fix: Provide useful info on permission errors#4096
Merged
Conversation
Prevents the very confusing 'Unsupported Docker Architecture' error when we actually had a permission error running docker.
Dav1dde
approved these changes
Dec 9, 2025
Dav1dde
approved these changes
Dec 9, 2025
Member
There was a problem hiding this comment.
Technically correct info, but I am blind (pls ignore).
I think that should do:
dav1d@colima:xy$ FOO="123"
dav1d@colima:xy$ export FOO
dav1d@colima:xy$ bash
dav1d@colima:xy$ echo $FOO
123
dav1d@colima:xy$ exit
dav1d@colima:xy$ unset FOO
dav1d@colima:xy$ FOO="123"
dav1d@colima:xy$ bash
dav1d@colima:xy$ echo $FOO
dav1d@colima:xy$
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4096 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 3 3
Lines 207 207
=======================================
Hits 206 206
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aldy505
reviewed
Dec 9, 2025
Comment on lines
+28
to
+33
| if [[ "$DOCKER_ARCH_OUTPUT" == *"permission denied"* ]]; then | ||
| echo "" | ||
| echo "You may need to add your user to the docker group:" | ||
| echo " sudo usermod -aG docker \$USER" | ||
| echo "Then log out and log back in, or run: newgrp docker" | ||
| fi |
Collaborator
There was a problem hiding this comment.
There are two options from here, actually:
- Include yourself into the docker group
- Run the install.sh script with sudo
Member
Author
There was a problem hiding this comment.
Just got this auto-merged so happy if you wanna change :D
Collaborator
There was a problem hiding this comment.
2. Run the install.sh script with sudo
Let's not suggest bad practices to users :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the very confusing 'Unsupported Docker Architecture' error when we actually had a permission error running docker.