Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

fix: preview package manager#269

Merged
bruno-garcia merged 1 commit intomasterfrom
fix/prefix-package
Feb 17, 2020
Merged

fix: preview package manager#269
bruno-garcia merged 1 commit intomasterfrom
fix/prefix-package

Conversation

@bruno-garcia
Copy link
Member

No description provided.

sdkVersion.setVersion(version);
sdkVersion.addPackage("sentry-core", version);
sdkVersion.addPackage("sentry-android-core", version);
sdkVersion.addPackage("maven:sentry-core", version);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's missing maven:sentry-android here, right? I remember asking it but not sure why

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, yes we are

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we don't know though. It's missing only if it was installed. Which we don't know here, do we? How can we figure out if that package was added? Maybe meta-data merging?

Copy link
Contributor

@marandaneto marandaneto Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could through reflection or adding something to manifest and check it on runtime or the backend side does the grouping and will know if android-core and android-ndk are there, but yes on the client side would be easier and less error-prone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, will raise for that

@bruno-garcia bruno-garcia merged commit b736f16 into master Feb 17, 2020
@bruno-garcia bruno-garcia deleted the fix/prefix-package branch February 17, 2020 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants