This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Enable the initialization using argument passing style in addition to the callback style configuration. #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Currently, Sentry only allows for callback-style initialization using
OptionsConfigurationinterface passed into theSentry.init()methods. This PR makes available to users also the initialization method that merely accepts theSentryOptionsinstance.Additionally, I've removed the unnecessary generic parameter on the
initmethod that was made public, because it naturally accepts any subclass ofSentryOptionsjust by inheritance rules.💡 Motivation and Context
The callback-based initialization is limiting in the injection-based environments like Spring or CDI where instances are produced and injected rather than modified through a callback.
💚 How did you test it?
N/A
📝 Checklist