Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

libs don't need to generate BuildConfig and lints check don't need to run over Release type as well every time.

💡 Motivation and Context

Speed up the build.
It doesn't generate the useless BuildConfig for libs.

💚 How did you test it?

Debugging and changing the unit tests to not use BuildConfig.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     13.61%   13.61%           
  Complexity       66       66           
=========================================
  Files            36       36           
  Lines           764      764           
  Branches         18       18           
=========================================
  Hits            104      104           
  Misses          658      658           
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587ed63...db574f2. Read the comment docs.

@marandaneto marandaneto merged commit 8f9a5c0 into master Oct 14, 2019
@marandaneto marandaneto deleted the feat/no_build_config branch October 14, 2019 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants